Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.12 base for non-pytest/min coverage checks #1018

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

bharat-thotakura
Copy link
Contributor

@bharat-thotakura bharat-thotakura commented Aug 8, 2024

This PR updates the CI checks to use a Python 3.12 base instead of Python 3.8 (which reaches EOL in Oct 2024). This will also allow the pipeline to run against the latest versions of the css and qss dependencies as some newer releases have already dropped support for Python 3.8/3.9 for example.

@bharat-thotakura bharat-thotakura changed the title Use Python 3.12 base for non-pytest checks Use Python 3.12 base for non-pytest/min coverage checks Aug 8, 2024
@bharat-thotakura
Copy link
Contributor Author

bharat-thotakura commented Aug 8, 2024

Unrelated to this PR specifically, but I think we should enforce the superstaq / Pytest and Coverage check (3.12) (pull_request) check as Required like the other coverage checks

Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

supermarq-benchmarks/supermarq/plotting.py Outdated Show resolved Hide resolved
@richrines1
Copy link
Contributor

Unrelated to this PR specifically, but I think we should enforce that the superstaq / Pytest and Coverage check (3.12) (pull_request) check as Required like the other coverage checks

done.

bharat-thotakura added a commit that referenced this pull request Aug 9, 2024
@bharat-thotakura bharat-thotakura merged commit f2a8b37 into main Aug 9, 2024
19 checks passed
@bharat-thotakura bharat-thotakura deleted the use-newer-python-ci branch August 9, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants